[ssh_x509] [PATCH] include xmalloc.h in ssh-rsa.c

ssh_x509 at roumenpetrov.info ssh_x509 at roumenpetrov.info
Sun Mar 1 20:08:55 EET 2015


> (have been looking over compiler warnings). I don't know that the
> severity of this is, but in authfile.c:
> int ok;
> ok = eng_key_load_private_type(type, filename + 7,
In openssh authfile.c is 'library like' but I miss this conversion.

In current version eng_key_load_private_type is also changed to be 
'library like' and the code is:
...
#ifdef USE_OPENSSL_ENGINE
     if (strncmp(filename, "engine:", 7) == 0) {
         r = eng_key_load_private_type(type, filename + 7,
             passphrase, keyp, commentp);
         if (perm_ok != NULL)
             *perm_ok = (r == SSH_ERR_SUCCESS) ? 1 : 0;
         return r;
     }
#endif
...

For previous version could be used following:
...
         *keyp = eng_key_load_private_type(type, filename + 7,
             passphrase, commentp);
         if (perm_ok != NULL)
             *perm_ok = *keyp ? 1 : 0;
         return *keyp ? SSH_ERR_SUCCESS : SSH_ERR_INVALID_FORMAT;
...
Error is not precises but should work.


[SNIP]
Regards,
Roumen




More information about the ssh_x509 mailing list